Update on the usage of deprecated Vacuum constants & module service import. #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on https://developers.home-assistant.io/blog/2024/06/12/async_forward_entry_setups/ it is possible to replace it with `async_forward_entry_setups` instead, which accepts multiple platforms and it should be more efficient.
This change is needed as the deprecated constants will be removed in version 2026.1.
This change removes the deprecated call to `hass.helpers.service` to use the recommended function import, so it works on 2026.1.
|
I just noticed that part of my work was made before here: #1810 so I'm more than happy to rebase after that PR gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following:
VacuumActivity.RETURNINGinstead ofSTATE_RETURNINGVacuumActivity.PAUSEDinstead of STATE_PAUSED`VacuumActivity.IDLEinstead ofSTATE_IDLEVacuumActivity.ERRORinstead of STATE_ERROR`VacuumActivity.DOCKEDinstead ofSTATE_DOCKEDVacuumActivity.CLEANINGinstead ofSTATE_CLEANINGfrom homeassistant.helpers.service import async_register_admin_serviceinstead ofhass.helpers.service.async_register_admin_service.